Check for NULL earlier in input_provided() #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Carson, thanks for taking this on! And I think it makes sense that the maintainership for this is passed over to somebody on the Shiny team. I'll forward the CRAN email for the resubmission request and we'll follow the necessary steps for changing maintainer on submission. |
|
Sounds good, I'll start another PR for the submission. This PR is ready to merge, but I'll need your approval to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73
Note that this PR is basically the same as rstudio/shiny#3908, which makes a similar change to
isTruthy()(it's implementation is basically copied here inshinyvalidate::input_provided())PS., @rich-iannone, let me know if you'd like to hand over maintainer-ship of
{shinyvalidate}(either way, I can put together a submission for you)